Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove false statement about unhandled exceptions in ScopeGuard #575

Merged
merged 2 commits into from
Sep 1, 2024

Conversation

JBludau
Copy link
Contributor

@JBludau JBludau commented Aug 31, 2024

fixes #554

ScopeGuard does not help you in case of unhandled exceptions.

@JBludau JBludau requested a review from dalg24 August 31, 2024 14:04
Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but please turn RAII into an hyper reference

docs/source/API/core/initialize_finalize/ScopeGuard.rst Outdated Show resolved Hide resolved
@dalg24 dalg24 merged commit 057e4b5 into kokkos:main Sep 1, 2024
2 checks passed
@JBludau JBludau deleted the scopeguard_explanation_fix branch September 1, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation of ScopeGuard seems misleading about unhandled exceptions
2 participants