Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptions for tile size getters in MDRangePolicy #563

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

ldh4
Copy link
Contributor

@ldh4 ldh4 commented Aug 13, 2024

Related to kokkos/kokkos#6839.

Added descriptions for tile_size_recommended() and max_total_tile_size() in MDRangePolicy.

Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make it clear this is only available since Kokkos 4.5
Potentially with a // (since Kokkos 4.5) comment or/and with a note

@ldh4
Copy link
Contributor Author

ldh4 commented Aug 13, 2024

Please make it clear this is only available since Kokkos 4.5 Potentially with a // (since Kokkos 4.5) comment or/and with a note

Notes added, indicating that the functions are available since Kokkos 4.5.

@dalg24 dalg24 merged commit b30fe1a into kokkos:main Aug 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants