Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about ChunkSize explicit constructor since 4.4 #561

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

tcclevenger
Copy link
Contributor

I chose to use a "note", but I'm happy to switch to a "warning" or bold text (done other places) or other suggestions.

@tcclevenger tcclevenger added the documentation Improvements or additions to documentation label Aug 6, 2024
@tcclevenger tcclevenger self-assigned this Aug 6, 2024
Copy link
Contributor

@nliber nliber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is fine. While the code fix is a breaking change, my expectation is that virtually no one took advantage of the previous behavior and if they did, the change to their code is minimal and not unexpected when working with C++.

Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tcclevenger
Copy link
Contributor Author

@dalg24 added explicit specifier.

@dalg24 dalg24 merged commit eb3e5a7 into kokkos:main Aug 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants