Consolidate virtual function pages #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dalg24 noticed that there are two pages on the topic of kokkos and virtual functions.
After a quick discussion on slack we propose to consolidate it and move it into the Programming Guide. We feel it relates more to the kokkos programming model than the use cases.
Nevertheless, this is open for discussion.
The consolidation basically consists of moving the special case (merged in #162) of the compiler optimization strategy circumventing Vtable lookup into the Programming Guide. With this done, the rest of the virtual functions usecase page was an exact copy of the page in the Programming Guide and is dropped.
Some resources are moved accordingly.