Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update README to reflect CronJobSource renamed to PingSource #6175

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

LYSingD
Copy link
Contributor

@LYSingD LYSingD commented Dec 13, 2024

"Fixes #issue-number" or "Add description of the problem this PR solves"

Proposed Changes

  • Update the documentation. Since knative/eventing#2412 updated the resource name from CronJobSource to PingSource, the documentation is misleading;

Since [knative/eventing#2412](knative/eventing#2412) updated the resource name from CronJobSource to PingSource, the documentation is misleading.
Copy link

linux-foundation-easycla bot commented Dec 13, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link

knative-prow bot commented Dec 13, 2024

Welcome @LYSingD! It looks like this is your first PR to knative/docs 🎉

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 13, 2024
@knative-prow knative-prow bot requested review from mmejia02 and pierDipi December 13, 2024 19:13
Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d148363
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/675c875ba8a0e200087b7fc3
😎 Deploy Preview https://deploy-preview-6175--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dprotaso
Copy link
Member

/assign @pierDipi @Cali0707 @Leo6Leo

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2025
Copy link

knative-prow bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LYSingD, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2025
@knative-prow knative-prow bot merged commit 4e1b454 into knative:main Jan 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants