Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WG leads to docs approvers #5968

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

pierDipi
Copy link
Member

Every time there is a new page added, I cannot approve PRs (example #5916), so I'm adding WG leads to the top-level directory approvers

Signed-off-by: Pierangelo Di Pilato <[email protected]>
@knative-prow knative-prow bot requested a review from nainaz May 13, 2024 10:16
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 13, 2024
@knative-prow knative-prow bot requested a review from pmbanugo May 13, 2024 10:16
Copy link

netlify bot commented May 13, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 65354fe
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/6641e86d322c5c00087b64ed
😎 Deploy Preview https://deploy-preview-5968--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pierDipi
Copy link
Member Author

/cc @knative/technical-oversight-committee

@knative-prow knative-prow bot requested a review from a team May 13, 2024 10:17
@pierDipi pierDipi changed the title Add WG leads to approvers Add WG leads to docs approvers May 13, 2024
@pierDipi
Copy link
Member Author

/assign @knative/technical-oversight-committee

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me!

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2024
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the issue is approving page changes, would it make sense to add the working group leads as owners on the config directory rather than for all of docs? Though given that there's no docs team right now, perhaps it's better to have more folks able to approve for the whole repo?

@dprotaso
Copy link
Member

If the issue is approving page changes, would it make sense to add the working group leads as owners on the config directory rather than for all of docs? Though given that there's no docs team right now, perhaps it's better to have more folks able to approve for the whole repo?

Yeah - let's subdivide the owners to the various sections

@dprotaso
Copy link
Member

dprotaso commented Jun 4, 2024

@pierDipi can you update the PR?

Copy link

github-actions bot commented Sep 4, 2024

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 4, 2024
@Cali0707
Copy link
Member

Cali0707 commented Sep 4, 2024

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 4, 2024
@skonto
Copy link
Contributor

skonto commented Sep 16, 2024

@pierDipi gentle ping

Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 16, 2024
@github-actions github-actions bot closed this Jan 16, 2025
@pierDipi
Copy link
Member Author

/reopen

I still think WG leads need access to the whole project to change nav, etc, since most of the time WG leads have also contributed to docs extensively to be able to be approver of the entire docs

@knative-prow knative-prow bot reopened this Jan 16, 2025
Copy link

knative-prow bot commented Jan 16, 2025

@pierDipi: Reopened this PR.

In response to this:

/reopen

I still think WG leads need access to the whole project to change nav, etc, since most of the time WG leads have also contributed to docs extensively to be able to be approver of the entire docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pierDipi
Copy link
Member Author

and obviously, WG leads will approve PRs in their area of expertise or expedite/review PRs they know are ok

@dprotaso
Copy link
Member

and obviously, WG leads will approve PRs in their area of expertise or expedite/review PRs they know are ok

Yeah I agree - it's just the owner file right now will just tag doc approvers/reviewers first. So in addition to what you have we want to make sure we tag eventing approvers for eventing docs etc.

You can do that with separate owner files in nested directories

/lgtm
/approve

can you do the follow up in another PR?

Copy link

knative-prow bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2025
@knative-prow knative-prow bot merged commit faeeeb7 into knative:main Jan 16, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants