Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update en.json - SMTP Max. connections info #2133

Closed
wants to merge 1 commit into from
Closed

Update en.json - SMTP Max. connections info #2133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions i18n/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,7 @@
"settings.mailserver.idleTimeout": "Idle timeout",
"settings.mailserver.idleTimeoutHelp": "Time to wait for new activity on a connection before closing it and removing it from the pool (s for second, m for minute).",
"settings.mailserver.maxConns": "Max. connections",
"settings.mailserver.maxConnsHelp": "Maximum concurrent connections to the server.",
"settings.mailserver.maxConnsHelp": "Maximum concurrent connections to the server. Should = Message rate x Concurrency.",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't correct. Max conns can be anything and don't need to be message_rate x concurrency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I based it on your comment here #2069 (comment)

your SMTP pool's max conns is set to 10, which means at max, you can only send 10 messages concurrently

You should reduce concurrency to something like 5-10 (given you've sent max messages to 2) and increase SMTP max conns to match.

Would it be more accurate to say SMTP Max. connections should = the Performance -> Concurrency number?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your last comment in that issue also makes it sound like this current help text is incorrect:

If concurrency = 10 and message_rate = 10, then up to 10x10=100 messages may be pushed out every second

Per your comment, it sounds like "Message rate" is the actual limit, and "Concurrency" just enables it.

So I think the help text for each of the performance settings needs some tweaking/clarification.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should change the setting's label to Max message rate instead of Message rate.

Copy link
Contributor Author

@MaximilianKohler MaximilianKohler Nov 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you be getting 50k/minute with

Concurrency: 250
Message rate: 50

50/s x 60 seconds = 3k/minute.

To get 50k/minute you'd need something like

Concurrency: 2500
Message rate: 830
SMTP Max. connections 830??

Maximum number of messages to be sent out per second per worker in a second

This also doesn't make sense based on what you've said recently. Message Rate seems to be a hard limit, not a per-worker (concurrency) rate.

EDIT:

I just confirmed (#2069 (comment)) that "Message rate" is not "max message rate" since I had message rate at 10 and I was sending at 20/s.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the instance of the settings I shared (which keep getting tweaked based on campaigns) 250 workers with each worker doing a max of 50/sec = 12.5k/sec max. For larger campaigns, we spawn and add multiple SMTP servers and raise the limits accordingly.

hm, sending 20/sec with 10 in settings, I'll have to investigate that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

250 workers with each worker doing a max of 50/sec = 12.5k/sec max

Ok, I guess there's a communication issue because this indicates that the If concurrency = 10 and message_rate = 10, then up to 10x10=100 messages may be pushed out every second help text is correct, even though it sounded like you contradicted that recently.

Yet my own experiments indicate that help text is wrong.

  • You're sending at 50,000 per minute
  • 12500 per second is 750,000 per minute

None of this is making sense.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lost track. After reviewing this, the help text is correct. It begins by saying Max... So it's the maximum upper limit permitted, but it does not mean that the program can actually push out so many e-mails to an SMTP server. There are many bottlenecks (CPU/network resources, database bottlenecks, network, and of course, the capacity of the SMTP server itself).

We've set an upper limit of 250 workers with 50/worker/sec max. With that, including all the bottlenecks (primarily the capacity of the SMTP servers to handle messages), we're achieving a net throughput of 50k. If the SMTP servers aren't performant, it can drop to any number. It doesn't mean that the system will be achieve a 750k/min throughput.

Basically, like the help text indicates, it is the Maximum upper limit, not a guarantee of any throughput.

"settings.mailserver.password": "Password",
"settings.mailserver.passwordHelp": "Enter to change",
"settings.mailserver.port": "Port",
Expand Down Expand Up @@ -463,7 +463,7 @@
"settings.media.upload.uri": "Upload URI",
"settings.media.upload.uriHelp": "Upload URI that is visible to the outside world. The media uploaded to upload_path will be publicly accessible under {root_url}, for instance, https://listmonk.yoursite.com/uploads.",
"settings.messengers.maxConns": "Max. connections",
"settings.messengers.maxConnsHelp": "Maximum concurrent connections to the server.",
"settings.messengers.maxConnsHelp": "Maximum concurrent connections to the server. Should = Message rate x Concurrency.",
"settings.messengers.messageSaved": "Settings saved. Reloading app ...",
"settings.messengers.name": "Messengers",
"settings.messengers.nameHelp": "eg: my-sms. Alphanumeric / dash.",
Expand Down
Loading