Skip to content
This repository has been archived by the owner on Jan 8, 2025. It is now read-only.

refactor: remove load_word in favor of FromBytes #988

Merged
merged 2 commits into from
Sep 30, 2024
Merged

refactor: remove load_word in favor of FromBytes #988

merged 2 commits into from
Sep 30, 2024

Conversation

lordshashank
Copy link
Contributor

@lordshashank lordshashank commented Sep 28, 2024 •
edited by enitrat
Loading

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #906

What is the new behavior?

  • Removes the use of load_word in the codebase.
  • Uses from_be_bytes and from_be_bytes_partial instead for same functionality.

Does this introduce a breaking change?

  • Yes
  • No

This change is Reviewable

@enitrat
Copy link
Contributor

enitrat commented Sep 28, 2024

can you clear the commit history to remove changes related to ceil32 ?

enitrat
enitrat reviewed Sep 28, 2024
View reviewed changes
crates/evm/src/precompiles/ec_operations/ec_mul.cairo Outdated Show resolved Hide resolved
crates/evm/src/instructions/environmental_information.cairo Outdated Show resolved Hide resolved
crates/evm/src/instructions/system_operations.cairo Show resolved Hide resolved
crates/evm/src/instructions/system_operations.cairo Outdated Show resolved Hide resolved
crates/evm/src/precompiles/ec_operations/ec_mul.cairo Outdated Show resolved Hide resolved
crates/evm/src/memory.cairo Outdated Show resolved Hide resolved
crates/evm/src/memory.cairo Outdated Show resolved Hide resolved
@lordshashank lordshashank force-pushed the remove-load-word branch 2 times, most recently from 24924e5 to dd8a4f4 Compare September 28, 2024 17:56
enitrat
enitrat previously approved these changes Sep 28, 2024
View reviewed changes
@enitrat enitrat changed the title Remove load word refactor: remove load_word in favor of FromBytes Sep 30, 2024
@enitrat enitrat merged commit 4ce7e2d into kkrt-labs:main Sep 30, 2024
2 of 3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@enitrat enitrat enitrat left review comments

@ClementWalter ClementWalter Awaiting requested review from ClementWalter ClementWalter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dev: prefer from_be_bytes to load_word
2 participants
@lordshashank @enitrat