Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow custom controls to add one or more Option based attributes #1510

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

feat: Allow custom controls to add one or more Option based attributes #1510

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
eb5f190
feat: Allow custom controls to add one or more Option based attributes
lucasnetau Jan 29, 2024
94b191a
test: update jest setup to ensure window.crypto is defined
lucasnetau Jan 29, 2024
ea1f71e
fix: improve the layout for stage options using flexbox
lucasnetau Feb 20, 2024
9744eb3
fix: improve documentation for onAddOption
lucasnetau Feb 20, 2024
d034990
chore: fix function description
lucasnetau Feb 20, 2024
d861a93
chore: add initial tests for custom options
lucasnetau Feb 21, 2024
bfb1004
fix: add fieldName as a 4th field to the onAddOption callback optionI…
lucasnetau Feb 21, 2024
019e006
fix: exclude double clicks on anchors from triggering stage closure
lucasnetau Feb 21, 2024
d6f03d1
fix: allow an array index to be included in input name
lucasnetau Nov 13, 2024
d03c286
chore: sync package.json with upstream
lucasnetau Nov 13, 2024
46f3863
chore: simple documentation for custom Options attribute type
lucasnetau Nov 13, 2024
c4ceaeb
chore: mark test as failing. onSave callback is called in two differe…
lucasnetau Nov 13, 2024
9da2cc6
chore: silence error to console in test
lucasnetau Nov 13, 2024
29b4f23
fix: label.field-label needs to be inline to ensure required and help…
lucasnetau Nov 14, 2024
3dfaae2
fix: options attribute is stored in 'values' key, custom options are …
lucasnetau Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: exclude double clicks on anchors from triggering stage closure
  • Loading branch information
@lucasnetau
lucasnetau committed Nov 13, 2024
commit 019e00688f75e2bebb9910db4752e1b20cd02f48
2 changes: 1 addition & 1 deletion src/js/form-builder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1723,7 +1723,7 @@ function FormBuilder(opts, element, $) {

$stage.on('dblclick', 'li.form-field', e => {
if (
['select', 'input', 'label', 'textarea'].includes(e.target.tagName.toLowerCase()) ||
['select', 'input', 'label', 'textarea', 'a',].includes(e.target.tagName.toLowerCase()) ||
e.target.isContentEditable === true
) {
return
Expand Down