-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): EmbeddedFlow task #6625
base: develop
Are you sure you want to change the base?
Conversation
I think we need @anna-geller view on the naming before merging as she's the one who have design the issue #6518 in details. |
cf5c1f3
to
0822ad8
Compare
We decided on I have a strong preference for Some of the limitations mentioned are a blocker 😢 e.g. this one -- we need to find a solution, we can't merge without it -- did you look at suggestions for implementation from the issue?
|
0822ad8
to
5829b75
Compare
Next steps after a meeting
Example showing why this needs to be a dedicated task: - id: subflow_call
type: io.kestra.plugin.core.flow.EmbeddedSubflow
namespace: company.team
flowId: critical_service
inputs:
myInput1: "{{ outputs.t1.myInput }}"
myInput2: "{{ inputs.myparentInput }}"
# Not available properties
wait: true
transmitFailed: true
labels: map |
5829b75
to
7b9b9bd
Compare
Adds an EmbeddedFlow that allow to embed subflow tasks into a parent tasks. Fixes #6518
7b9b9bd
to
8ae291d
Compare
d2d8668
to
0c3ed3b
Compare
320a3a3
to
be30034
Compare
Adds an EmbeddedFlow that allow to embed subflow tasks into a parent task.
After discussion with @Ben8t, the task has been called EmbeddedFlow and not TaskGroup as it better describes what it does (embedding a subflow inside a parent flow).
Fixes #6518
Limitation of the current prototypes: