Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apiary.apib #1414

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update apiary.apib #1414

wants to merge 1 commit into from

Conversation

tomasfejfar
Copy link
Contributor

https://github.com/keboola/ai-service/pull/131/files/4b0b1189ca6d08151516d4357372591212fd632c#r1820368987

Jira: CT-XXX
KBC: XXX

Before asking for review make sure that:

Checklist

  • New client method(s) has tests
  • New client method(s) support branches, or they are listed in BranchAwareClient
  • Apiary file is updated

Release

  • I gave the PR a proper label:
    • major (BC break)
    • minor (new feature)
    • patch (backwards compatible fix)
    • no release (just test changes)

@tomasfejfar tomasfejfar added the no release just test changes label Oct 29, 2024
@tomasfejfar tomasfejfar requested review from a team and zajca and removed request for a team October 29, 2024 08:57
Copy link
Contributor

@jirkasemmler jirkasemmler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jen si to chci vyjasnit, jinak ok

@@ -7690,11 +7690,12 @@ Updates an existing configuration for [Development Branch](#reference/developmen
+ Response 204 (application/json)

### Delete Configuration [DELETE /v2/storage/branch/{branch_id}/components/{component_id}/configs/{config_id}]
Deletes a development branch configuration. When a configuration is deleted, it is only marked as deleted and remains still available in the system.
Deletes a configuration. When a configuration is deleted, it is only marked as deleted and remains still available in the system.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Deletes a configuration. When a configuration is deleted, it is only marked as deleted and remains still available in the system.
Deletes a configuration in specified branch. When a configuration is deleted, it is only marked as deleted and remains still available in the system.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jakoze nevim proc ti ten Deletes a development branch configuration vadil . zni sice divne, ale imho ma pravdu a melo by se to zminit. Nebo ne?

@zajca zajca removed their request for review February 6, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no release just test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants