Merge pull request #470 from keboola/kbc-646-remove-test-for-automati…

…c-datatypes-redshift-synapse KBC-646 remove test for automatic datatypes redshift synapse
keboola · Aug 19, 2020 · a7a99fb · a7a99fb
2 parents 2216273 + 977555d
commit a7a99fb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 56 deletions.
diff --git a/tests/Backend/Workspaces/MetadataFromRedshiftWorkspaceTest.php b/tests/Backend/Workspaces/MetadataFromRedshiftWorkspaceTest.php
@@ -179,28 +179,12 @@ public function testCopyImport()
             $this->_client->getTableDataPreview($table_id, array('format' => 'rfc')),
             'imported data comparsion'
         );
-        // check the created metadata
-        $expectedIdMetadata = [
-            'KBC.datatype.type' => 'INT4',
-            'KBC.datatype.nullable' => '',
-            'KBC.datatype.basetype' => 'INTEGER',
-        ];
-        $expectedNameMetadata = [
-            'KBC.datatype.type' => 'VARCHAR',
-            'KBC.datatype.nullable' => '',
-            'KBC.datatype.basetype' => 'STRING',
-            'KBC.datatype.length' => '256',
-            'KBC.datatype.default' => 'honza',
-        ];
 
         // check that the new table has the correct metadata
         $table = $this->_client->getTable($table_id);
 
         $this->assertEquals([], $table['metadata']);
-        $this->assertArrayHasKey('id', $table['columnMetadata']);
-        $this->assertMetadata($expectedIdMetadata, $table['columnMetadata']['id']);
-        $this->assertArrayHasKey('name', $table['columnMetadata']);
-        $this->assertMetadata($expectedNameMetadata, $table['columnMetadata']['name']);
+        $this->assertEquals([], $table['columnMetadata']);
         $db->query("truncate table \"test.Languages3\"");
         $db->query("alter table \"test.Languages3\" ADD COLUMN \"update\" varchar(64)");
         $db->query("insert into \"test.Languages3\" values " .
@@ -224,18 +208,9 @@ public function testCopyImport()
             $this->_client->getTableDataPreview($table['id'], array('format' => 'rfc')),
             'new  column added'
         );
-        $expectedUpdateMetadata = [
-            'KBC.datatype.type' => 'VARCHAR',
-            'KBC.datatype.nullable' => '1',
-            'KBC.datatype.basetype' => 'STRING',
-            'KBC.datatype.length' => '64',
-        ];
         $table = $this->_client->getTable($table['id']);
         $this->assertEquals([], $table['metadata']);
-        $this->assertArrayHasKey("id", $table['columnMetadata']);
-        $this->assertArrayHasKey("name", $table['columnMetadata']);
-        $this->assertArrayHasKey("update", $table['columnMetadata']);
-        $this->assertMetadata($expectedUpdateMetadata, $table['columnMetadata']['update']);
+        $this->assertEquals([], $table['columnMetadata']);
     }
 
     public function testWriteTableFromWorkspaceWithUnsupportedDataType()

diff --git a/tests/Backend/Workspaces/MetadataFromSynapseWorkspaceTest.php b/tests/Backend/Workspaces/MetadataFromSynapseWorkspaceTest.php
@@ -174,29 +174,12 @@ public function testCopyImport()
             $this->_client->getTableDataPreview($table_id, array('format' => 'rfc')),
             'imported data comparsion'
         );
-        // check the created metadata
-        $expectedIdMetadata = [
-            'KBC.datatype.type' => 'INT',
-            'KBC.datatype.nullable' => '',
-            'KBC.datatype.basetype' => 'INTEGER',
-        ];
-        $expectedNameMetadata = [
-            'KBC.datatype.type' => 'VARCHAR',
-            'KBC.datatype.nullable' => '',
-            'KBC.datatype.basetype' => 'STRING',
-            'KBC.datatype.length' => '50',
-            'KBC.datatype.default' => '\'honza\'',
-        ];
-
 
         // check that the new table has the correct metadata
         $table = $this->_client->getTable($table_id);
 
         $this->assertEquals([], $table['metadata']);
-        $this->assertArrayHasKey('id', $table['columnMetadata']);
-        $this->assertMetadata($expectedIdMetadata, $table['columnMetadata']['id']);
-        $this->assertArrayHasKey('name', $table['columnMetadata']);
-        $this->assertMetadata($expectedNameMetadata, $table['columnMetadata']['name']);
+        $this->assertEquals([], $table['columnMetadata']);
 
         $db->query("truncate table $quotedTableId");
         $db->query("alter table $quotedTableId ADD \"update\" varchar(64) NOT NULL DEFAULT '';");
@@ -222,19 +205,10 @@ public function testCopyImport()
             $this->_client->getTableDataPreview($table['id'], array('format' => 'rfc')),
             'new  column added'
         );
-        $expectedUpdateMetadata = [
-            'KBC.datatype.type' => 'VARCHAR',
-            'KBC.datatype.nullable' => '',
-            'KBC.datatype.basetype' => 'STRING',
-            'KBC.datatype.length' => '64',
-            'KBC.datatype.default' => '\'\'',
-        ];
+
         $table = $this->_client->getTable($table['id']);
         $this->assertEquals([], $table['metadata']);
-        $this->assertArrayHasKey("id", $table['columnMetadata']);
-        $this->assertArrayHasKey("name", $table['columnMetadata']);
-        $this->assertArrayHasKey("update", $table['columnMetadata']);
-        $this->assertMetadata($expectedUpdateMetadata, $table['columnMetadata']['update']);
+        $this->assertEquals([], $table['columnMetadata']);
     }
 
     private function assertMetadata($expectedKeyValues, $metadata)