test: Temporary pipeline error #2241
Conversation
jachym-tousek-keboola
force-pushed
the
jt-pipeline-test
branch
2 times, most recently
from
36da66b to
afe3f2a
Compare
jachym-tousek-keboola
requested review from
Matovidlo and
hosekpeter
as code owners
| {"level":"debug","message":"flushing writers"} | ||
| {"level":"debug","message":"chunk completed, aligned = true, size = \"5B\""} | ||
| {"level":"debug","message":"writers flushed"} | ||
| {"level":"warn","message":"chunks write failed: some error, waiting %s, chunks count = 1"} |
There was a problem hiding this comment.
I don't see log where chunks were written after fail
There was a problem hiding this comment.
The chunk completed message didn't appear in the logs. I'm not quite sure why to be honest because I don't understand how chunk writer works. The message is logged in swapChunks which I'm guessing wasn't necessary to be called in this case? However the data did appear in the stream output and I do assert that.
There was a problem hiding this comment.
I see that we assert the data but it is weird, we receive chunk write failed and being in backoff and do not see it write after backoff interval is reached. See encoding/pipeline.go:493. The operation is again retried and chunks are processed
There was a problem hiding this comment.
I think you made a typo? encoding/pipeline.go only has 480 lines so I'm not sure what line you're referring to. Anyway yes chunks are processed but I'm guessing swapChunks didn't happen or didn't do anything so it didn't get logged. Should I spend more time trying to understand what's going on with the chunk writer?
There was a problem hiding this comment.
There was a problem hiding this comment.
I think the log is supposed to be there so you need to spend more time on that why it is missing. E.g deadlock occured, didn't wait enough or any other issue
There was a problem hiding this comment.
It is actually missing on the old tests from Michal as well... Apparently the chunk is still active until you send the next record so it only gets completed when you do send the next one. But I added assertions for "chunk written" which is logged immediately.
There was a problem hiding this comment.
So if it is missing in old tests why don't we add this into them? I understand that the chunks can be processed retrospectivelly but I would expect test to cover it fully. Or add commentary somewhere, maybe into processChunks metohd
jachym-tousek-keboola
force-pushed
the
jt-pipeline-test
branch
from
afe3f2a to
627e8fa
Compare
Jira: https://keboola.atlassian.net/browse/PSGO-1004
Changes: