Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: GitLab provider #2231

Merged
merged 3 commits into from
Feb 5, 2025
Merged

feat: GitLab provider #2231

merged 3 commits into from
Feb 5, 2025

Conversation

jachym-tousek-keboola
Copy link
Contributor

Jira: https://keboola.atlassian.net/browse/PSGO-991

Changes:

  • Added GitLab provider for apps proxy

@jachym-tousek-keboola jachym-tousek-keboola force-pushed the jt-psgo-991-gitlab-provider branch from 7a58e70 to 8dddf4c Compare January 31, 2025 13:40
@jachym-tousek-keboola jachym-tousek-keboola marked this pull request as ready for review January 31, 2025 13:55
Copy link

github-actions bot commented Feb 3, 2025

Apps Proxy Kubernetes Diff [CI]

Between base abd2d93 ⬅️ head d552474.

Expand
--- /tmp/artifacts/test-k8s-state.old.json.processed.kv	2025-02-03 08:57:41.123638078 +0000
+++ /tmp/artifacts/test-k8s-state.new.json.processed.kv	2025-02-03 08:57:41.210637881 +0000
@@ -114 +114 @@
-<Deployment/apps-proxy>.spec.template.spec.containers[0].image = "docker.io/keboola/apps-proxy:abd2d93-1738572638";
+<Deployment/apps-proxy>.spec.template.spec.containers[0].image = "docker.io/keboola/apps-proxy:d552474-1738572922";
@@ -497,3 +497,3 @@
-<Pod/apps-proxy-<hash>>.spec.containers[0].image = "docker.io/keboola/apps-proxy:abd2d93-1738572638";
-<Pod/apps-proxy-<hash>>.spec.containers[0].image = "docker.io/keboola/apps-proxy:abd2d93-1738572638";
-<Pod/apps-proxy-<hash>>.spec.containers[0].image = "docker.io/keboola/apps-proxy:abd2d93-1738572638";
+<Pod/apps-proxy-<hash>>.spec.containers[0].image = "docker.io/keboola/apps-proxy:d552474-1738572922";
+<Pod/apps-proxy-<hash>>.spec.containers[0].image = "docker.io/keboola/apps-proxy:d552474-1738572922";
+<Pod/apps-proxy-<hash>>.spec.containers[0].image = "docker.io/keboola/apps-proxy:d552474-1738572922";
@@ -924 +924 @@
-<ReplicaSet/apps-proxy-<hash>>.spec.template.spec.containers[0].image = "docker.io/keboola/apps-proxy:abd2d93-1738572638";
+<ReplicaSet/apps-proxy-<hash>>.spec.template.spec.containers[0].image = "docker.io/keboola/apps-proxy:d552474-1738572922";


(see artifacts in the Github Action for more information)

Copy link
Contributor

@Matovidlo Matovidlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hosekpeter hosekpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Matovidlo Matovidlo merged commit 3e7a900 into main Feb 5, 2025
13 checks passed
@Matovidlo Matovidlo deleted the jt-psgo-991-gitlab-provider branch February 5, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants