fix: ld_classic is deprecated

keboola · Nov 6, 2024 · ba9238f · ba9238f
1 parent d25244c
commit ba9238f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/.github/workflows/test-e2e-cli.yml b/.github/workflows/test-e2e-cli.yml
@@ -69,15 +69,14 @@ jobs:
           
           # Prevent linker warnings on macOs (https://github.com/golang/go/issues/61229#issuecomment-1988965927)
           if [ "$RUNNER_OS" == "macOS" ]; then
-            export GOFLAGS="-ldflags=-extldflags=-Wl,-ld_classic"
+            export OTHER_LDFLAGS="-Wl,-ld_classic"
           fi
           
           # Build binary for test without external inputs
           env -i  \
             TERM="$TERM" \
             HOME="$HOME" \
             PATH="$PATH" \
-            GOFLAGS="$GOFLAGS" \
             APPDATA="$APPDATA" \
             BUILD_TARGET_PATH="$TEST_BINARY_CLI" \
             CLI_BUILD_DATE="-" \

diff --git a/.github/workflows/test-unit.yml b/.github/workflows/test-unit.yml
@@ -88,15 +88,14 @@ jobs:
         run: |
           # Prevent linker warnings on macOs (https://github.com/golang/go/issues/61229#issuecomment-1988965927)
           if [ "$RUNNER_OS" == "macOS" ]; then
-            export GOFLAGS="-ldflags=-extldflags=-Wl,-ld_classic"
+            export OTHER_LDFLAGS="-Wl,-ld_classic"
           fi
           
           # ENVs can affect test caching, make sure to only run tests with expected ENVs
           env -i  \
             TERM="$TERM" \
             HOME="$HOME" \
             PATH="$PATH" \
-            GOFLAGS="$GOFLAGS" \
             APPDATA="$APPDATA" \
             DATADOG_ENABLED="false" \
             UNIT_ETCD_ENABLED="$UNIT_ETCD_ENABLED" \