Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix columns nullability #126

Merged
merged 2 commits into from
Jan 8, 2025
Merged

fix columns nullability #126

merged 2 commits into from
Jan 8, 2025

Conversation

@ondrajodas ondrajodas requested a review from AdamVyborny January 8, 2025 12:30
@ondrajodas
Copy link
Contributor Author

@AdamVyborny můžeš pls asap, máme na to ticket a ty sloupečky by měly být null, protože z APIčka přichází prázdné hodnoty

@AdamVyborny
Copy link
Contributor

@ondrajodas ještě to tam padá, mění se tam víc věcí než jen nullabilita. To je OK?

@ondrajodas ondrajodas force-pushed the ondra-fix-nullable-columns branch from ecee9c5 to cb9034f Compare January 8, 2025 12:41
@ondrajodas
Copy link
Contributor Author

@AdamVyborny ne mění se jen nullabilita... jen když jsem fixoval testy tak jsem přepsal blbý manifesty :D teď by to mělo být ok

Copy link
Contributor

@AdamVyborny AdamVyborny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Teď už OK. LGTM

@ondrajodas ondrajodas merged commit 85ff382 into master Jan 8, 2025
1 check passed
@ondrajodas ondrajodas deleted the ondra-fix-nullable-columns branch January 8, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants