Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Native Types support #141

Merged
merged 6 commits into from
Jul 5, 2024
Merged

New Native Types support #141

merged 6 commits into from
Jul 5, 2024

Conversation

AdamVyborny
Copy link
Contributor

@AdamVyborny AdamVyborny commented Jun 20, 2024 •
edited
Loading

@AdamVyborny AdamVyborny force-pushed the adamvyborny-PST-1418 branch from 4570509 to 25663d4 Compare June 20, 2024 09:52
@AdamVyborny AdamVyborny force-pushed the adamvyborny-PST-1418 branch from 25663d4 to 49fc50e Compare June 20, 2024 09:55
@AdamVyborny AdamVyborny requested a review from ondrajodas June 20, 2024 10:08
@zajca
Copy link
Member

zajca commented Jun 20, 2024

ty vole co je to za zkratku nntf :D za měsíc nebudeš vědět co to je :D

@AdamVyborny
Copy link
Contributor Author

AdamVyborny commented Jun 20, 2024 •
edited
Loading

ty vole co je to za zkratku nntf :D za měsíc nebudeš vědět co to je :D

To je oficiální zkratka. https://keboola.atlassian.net/browse/PST-1360

@ondrajodas ondrajodas changed the title NNTF support New Native Types support Jun 21, 2024
ondrajodas
ondrajodas approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@ondrajodas ondrajodas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jo dobrý, jen opravdu bych i ten test přejmenoval na run-action-native-types-manifest

@ondrajodas ondrajodas self-requested a review June 21, 2024 11:42
ondrajodas
ondrajodas requested changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@ondrajodas ondrajodas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vlastně ne dobrý... jedna věc

...ctional/run-action-nntf-manifest/expected/data/out/tables/in.c-main.escaping.csv.gz.manifest Outdated
"data_type": {
"base": {
"length": "16777216",
"type": "VARCHAR"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tohle není base type, ale snowflake type... base type je STRING

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ondrajodas Týká se to custom quries jen. Tam to beru z toho Column value objektu. Tak mám ty typy u custom queries úplně vyhodit? Předtím tam taky nebyly...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no pokud je víme tak by tam být měly ale ne v base typu

@AdamVyborny AdamVyborny requested a review from ondrajodas June 27, 2024 09:34
ondrajodas
ondrajodas approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@ondrajodas ondrajodas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zkoušel jsem to v kbc a vypadá to už cajk 👍
https://connection.keboola.com/admin/projects/10041/queue/1147826307

kde je manifest tabulky
in.c-keboola-ex-db-snowflake-1147810229.tabledefinition.csv.gz.manifest.json

takže dobrý

@AdamVyborny AdamVyborny merged commit 76b60fd into master Jul 5, 2024
2 checks passed
@AdamVyborny AdamVyborny deleted the adamvyborny-PST-1418 branch July 5, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrajodas ondrajodas ondrajodas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdamVyborny @zajca @ondrajodas