fix: add skipRegionValidation to test expectations

keboola · Feb 2, 2025 · 9b8a8fb · 9b8a8fb
1 parent d5a5255
commit 9b8a8fb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/Config/ConfigDefinition.php b/src/Config/ConfigDefinition.php
@@ -106,7 +106,6 @@ protected function getParametersDefinition(): ArrayNodeDefinition
                 ->scalarNode('#secret_access_key')->end()
                 ->scalarNode('#bucket')->end()
                 ->scalarNode('#jsonKey')->end()
-                ->scalarNode('region')->end()
             ->end()
         ;
         // @formatter:on

diff --git a/tests/phpunit/ConfigTest.php b/tests/phpunit/ConfigTest.php
@@ -107,6 +107,7 @@ public function validConfigDataProvider(): Generator
             ],
             [
                 'storageBackendType' => Config::STORAGE_BACKEND_S3,
+                'skipRegionValidation' => false,
             ],
             '.',
             false,
@@ -133,6 +134,7 @@ public function validConfigDataProvider(): Generator
                 '#secret_access_key' => 'testAccessKey',
                 'region' => 'testRegion',
                 '#bucket' => 'testBucket',
+                'skipRegionValidation' => false,
             ],
             '.',
             false,
@@ -157,6 +159,7 @@ public function validConfigDataProvider(): Generator
                 'accountName' => 'testAccountName',
                 '#accountKey' => 'testAccountKey',
                 'region' => 'testRegion',
+                'skipRegionValidation' => false,
             ],
             '',
             false,
@@ -186,6 +189,7 @@ public function validConfigDataProvider(): Generator
                 '#secret_access_key' => 'testAccessKey',
                 'region' => 'testRegion',
                 '#bucket' => 'testBucket',
+                'skipRegionValidation' => false,
             ],
             '.',
             true,
@@ -216,6 +220,7 @@ public function validConfigDataProvider(): Generator
                 'accountName' => 'testAccountName',
                 '#accountKey' => 'testAccountKey',
                 'region' => 'testRegion',
+                'skipRegionValidation' => false,
             ],
             'testPath',
             true,
@@ -247,7 +252,7 @@ public function validConfigDataProvider(): Generator
                 'region' => 'testRegion',
                 '#bucket' => 'testBucket',
                 'backupPath' => 'testPath',
-
+                'skipRegionValidation' => false,
             ],
             'testPath/',
             true,
@@ -275,6 +280,7 @@ public function validConfigDataProvider(): Generator
                 'storageBackendType' => Config::STORAGE_BACKEND_ABS,
                 'accountName' => 'testAccountName',
                 '#accountKey' => 'testAccountKey',
+                'skipRegionValidation' => false,
             ],
             'testPath',
             true,