backupId can be null

keboola · Jan 22, 2025 · 36ff501 · 36ff501
1 parent b55506d
commit 36ff501
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 2 deletions.
diff --git a/src/Config/Config.php b/src/Config/Config.php
@@ -14,9 +14,11 @@ class Config extends BaseConfig
 
     public const STORAGE_BACKEND_GCS = 'gcs';
 
-    public function getBackupId(): string
+    public function getBackupId(): ?string
     {
-        return $this->getStringValue(['parameters', 'backupId'], '');
+        /** @var ?string $val */
+        $val = $this->getValue(['parameters', 'backupId'], '');
+        return $val;
     }
 
     public function getStorageBackendType(): string

diff --git a/tests/phpunit/ConfigTest.php b/tests/phpunit/ConfigTest.php
@@ -30,6 +30,33 @@ public function testValidConfig(
         Assert::assertEquals($expectedStorageBackendType, $config->getStorageBackendType());
     }
 
+    public function testBackupId(): void
+    {
+        $config = new Config([
+            'action' => 'run',
+            'parameters' => [
+                'backupId' => '123456',
+            ],
+            'image_parameters' => [
+                'storageBackendType' => Config::STORAGE_BACKEND_S3,
+            ],
+        ], new ConfigDefinition());
+
+        Assert::assertEquals('123456', $config->getBackupId());
+
+        $config = new Config([
+            'action' => 'run',
+            'parameters' => [
+                'backupId' => null,
+            ],
+            'image_parameters' => [
+                'storageBackendType' => Config::STORAGE_BACKEND_S3,
+            ],
+        ], new ConfigDefinition());
+
+        Assert::assertEquals('', $config->getBackupId());
+    }
+
     /** @dataProvider invalidConfigDataProvider */
     public function testInvalidConfig(array $configArray, string $expectedExceptionMessage): void
     {