✨ authz: add warrants to default rule resolver #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
sttts
force-pushed
the
sttts-warrants-1.31
branch
from
eca30de to
49075cf
Compare
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
sttts
force-pushed
the
sttts-warrants-1.31
branch
from
49075cf to
565a453
Compare
sttts
changed the title
mjudeikis
reviewed
Jan 17, 2025
| // WarrantExtraKey is the key used in a user's "extra" to specify | ||
| // JSON-encoded user infos for attached extra permissions for that user | ||
| // evaluated by the authorizer. | ||
| WarrantExtraKey = "authorization.kcp.io/warrant" |
There was a problem hiding this comment.
warrants? Are we doing Singelton or Plurar here, too?
|
Just a nit question for now but lets hold merging until we test this in downstream to see if there is any issues :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: