Adds core support for user role widget contexts #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasparsd
requested changes
Jul 17, 2017
| // | ||
|
|
||
| // Check for logged-out user | ||
| if( $settings['logged-out'] === '1' && $is_logged_in !== true ) { |
There was a problem hiding this comment.
@folkhack You should probably ensure that logged-out exists before using it. A good solution is wp_parse_args() with a set of defaults.
| } | ||
|
|
||
| $current_user = wp_get_current_user(); | ||
| $is_logged_in = ( $current_user->ID !== 0 && $current_user->ID ); |
There was a problem hiding this comment.
Could we use is_user_logged_in() instead?
| // Build whitelist of user roles that are allowed to see widget | ||
| $role_check_array = array(); | ||
|
|
||
| foreach( $settings as $role_key => $setting_val ) { |
There was a problem hiding this comment.
I think we can skip all of this if the user is not logged in, correct?
| asort( $roles ); | ||
|
|
||
| // First two options are the logged-in and logged-out options | ||
| $options[ 'logged-in' ] = __( 'When user is logged in (all types, global)', 'widget-context' ); |
There was a problem hiding this comment.
Maybe simplify these to User logged in and User logged out?
| // Add the roles that the user can currently edit as whitelist user role options | ||
| foreach( $roles as $role_key => $role_name ) { | ||
|
|
||
| $options[ 'role-' . $role_key ] = sprintf( __( 'When user has role "%s" (%s)', 'widget-context' ), $role_name, $role_key ); |
There was a problem hiding this comment.
And here, something like User role "%s"?
| function get_roles() { | ||
|
|
||
| global $wp_roles; | ||
| return apply_filters( 'editable_roles', $wp_roles->roles ); |
There was a problem hiding this comment.
@folkhack There is get_editable_roles() -- could we use that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
Long time fan, have been using your plugin for over 3 years now on 10 client sites!
Needed support for user roles within your Widget Context plugin and decided to take a Sunday afternoon and make a contribution.
Very clean code - was a joy to work within!
Thank you for your consideration, and please feel free to shoot me any feedback/critique =)
Sincerely,