Export logarte_dashboard_screen.dart and disableDebugConsoleLogs #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codel1417
changed the title
|
@Codel1417 hi. I see that you've helped me a lot here. I'll review the code ASAP, then merge and release the new version. Appreciate it. |
I appreciate all of your current and any future contributions. Can we make changes one by one by in a separate PRs? |
Done, though I haven't tested any of them separately. I split them using cherry-picking commits with some minor editing to fix merges |
|
Oh, that's very perfect that you've opened separate PRs for them. Thanks and let me review and test each. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to use go router, and my existing method to lock developer mode settings, So this exports the main dashboard.
also adds
disableDebugConsoleLogsfrom #3also exports the Level and adds it to info()
also adds an optional back button to the dashboard (off by default)
adds
logBufferLengthto limit the number of stored logs. defaults to 2500. #2adds a source value to 'info' logs which overwrites the source from Trace.source
I think this PR may continue to bloat as I make changes for myself