Merge pull request #1 from kabisa/change-to-templatefile

modified to use of templatefile()
kabisa · Apr 14, 2022 · c717f76 · c717f76
2 parents ffdca80 + 6c79850
commit c717f76
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 27 deletions.
diff --git a/iam.tf b/iam.tf
@@ -24,25 +24,25 @@ resource "aws_iam_policy" "external-dns-iam-policy" {
 }
 
 resource "aws_iam_role" "external-dns-iam-role" {
-  name               = "EksExternalDnsIAMRole"
+  name = "EksExternalDnsIAMRole"
   assume_role_policy = jsonencode(
-  {
-    Statement = [
-      {
-        Action    = "sts:AssumeRoleWithWebIdentity"
-        Condition = {
-          StringEquals = {
-            "${var.oidc_host_path}:aud" = "sts.amazonaws.com"
+    {
+      Statement = [
+        {
+          Action = "sts:AssumeRoleWithWebIdentity"
+          Condition = {
+            StringEquals = {
+              "${var.oidc_host_path}:aud" = "sts.amazonaws.com"
+            }
           }
-        }
-        Effect    = "Allow",
-        Principal = {
-          Federated = "arn:aws:iam::${var.account_id}:oidc-provider/${var.oidc_host_path}"
-        }
-      },
-    ]
-    Version   = "2012-10-17"
-  }
+          Effect = "Allow",
+          Principal = {
+            Federated = "arn:aws:iam::${var.account_id}:oidc-provider/${var.oidc_host_path}"
+          }
+        },
+      ]
+      Version = "2012-10-17"
+    }
   )
 }
 

diff --git a/main.tf b/main.tf
@@ -1,12 +1,3 @@
-data "template_file" "external-dns" {
-  template = file("${path.module}/yamls/external-dns-values.yaml")
-  vars     = {
-    region        = var.region
-    aws_role_arn  = aws_iam_role.external-dns-iam-role.arn
-    vpc_id        = var.vpc_id
-  }
-}
-
 resource "helm_release" "aws-load-balancer-controller" {
   name       = "external-dns"
   namespace  = "kube-system"
@@ -16,7 +7,14 @@ resource "helm_release" "aws-load-balancer-controller" {
   # appVersion: 0.7.6
 
   values = [
-    data.template_file.external-dns.rendered
+    templatefile(
+      "${path.module}/yamls/external-dns-values.yaml",
+      {
+        region       = var.region
+        aws_role_arn = aws_iam_role.external-dns-iam-role.arn
+        vpc_id       = var.vpc_id
+      }
+    )
   ]
 }