Skip to content
This repository has been archived by the owner on Oct 6, 2021. It is now read-only.

Package updates maji and project template #278

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Package updates maji and project template #278

wants to merge 3 commits into from

Conversation

seamyd
Copy link

@seamyd seamyd commented Sep 5, 2019

No description provided.

@seamyd seamyd requested a review from ruisalgado September 5, 2019 12:59
ruisalgado
ruisalgado suggested changes Sep 6, 2019
View reviewed changes
Copy link
Member

@ruisalgado ruisalgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect the project_template/yarn.lock file to also be updated

@pascalw
Copy link
Member

pascalw commented Sep 6, 2019

That's right @ruisalgado. I noticed it's missing in the https://github.com/kabisa/maji/blob/master/CONTRIBUTING.md doc however.

@seamyd if you run yarn bootstrap in the root of the repo the project template lockfile should also be updated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ruisalgado ruisalgado ruisalgado requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seamyd @pascalw @ruisalgado