-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix state restoration in the notebook extension #12218
Conversation
Thanks for making a pull request to jupyterlab! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @jtpio
Benchmark reportThe execution time (in milliseconds) are grouped by test file, test type and browser. The mean relative comparison is computed with 95% confidence. Results table
Changes are computed with expected as reference. |
@meeseeksdev please backport to 3.3.x |
…12226) Co-authored-by: Jeremy Tuloup <[email protected]>
References
As reported in https://github.com/jupyterlab/retrolab/issues/358, where some commands are not available in downstream applications like RetroLab since they don't include a
ILayoutRestorer
.Code changes
Fix the guard checking if the
restorer
is available, so it only surrounds the relevant logic.User-facing changes
Should fix some behavior in downstream applications reusing
@jupyterlab/notebook-extension:tracker
as is.Backwards-incompatible changes
None