Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md 2 #26

Merged
merged 13 commits into from
Jul 31, 2024
Merged

Update README.md 2 #26

merged 13 commits into from
Jul 31, 2024

Conversation

cronan03
Copy link
Collaborator

@cronan03 cronan03 commented Jul 30, 2024

Add mandatory GSoC report to README as it is set as the source of that report - I (@fcollonval) discovered to late some of the requirements so we cannot change the file as the link is frozen in GSoC evaluation database.

cronan03 added 2 commits July 30, 2024 20:54
final changes as per GSOC requirements
@fcollonval fcollonval added the documentation Improvements or additions to documentation label Jul 31, 2024
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cronan03

I have minor points - mainly typos.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
cronan03 and others added 8 commits July 31, 2024 18:13
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
Copy link
Collaborator Author

@cronan03 cronan03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fcollonval , the changes have been addressed

@fcollonval fcollonval enabled auto-merge (squash) July 31, 2024 15:59
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cronan03

@fcollonval fcollonval merged commit 58146d8 into main Jul 31, 2024
20 checks passed
@fcollonval fcollonval deleted the cronan03-patch-1 branch July 31, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants