Bump jupytercad #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trungleduc
force-pushed
the
bump-jupyter-cad
branch
from
5a93092 to
b08f39f
Compare
trungleduc
force-pushed
the
bump-jupyter-cad
branch
from
b08f39f to
7b39d28
Compare
martinRenou
requested changes
Feb 28, 2024
| @@ -27,9 +27,8 @@ classifiers = [ | |||
| "Programming Language :: Python :: 3.12", | |||
| ] | |||
| dependencies = [ | |||
| "jupyter_ydoc>=1.1.0,<2", | |||
| "y-py>=0.6.0,<0.7", | |||
There was a problem hiding this comment.
We should probably add pycrdt here
There was a problem hiding this comment.
I wanted to do this, but pinning a version of pycrdt is quite tricky since it is a dependency of a dependency of jupyter-collaboration, which is not a direct dependency of jupytercad-freecad
There was a problem hiding this comment.
should we add pycrdt without version constraints?
There was a problem hiding this comment.
ok. Well it's not too bad to not make it a dependency (until it is). Let's keep it that way for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.