Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility meta fixes #441

Merged
merged 7 commits into from
Dec 1, 2021
Merged

Conversation

palewire
Copy link
Collaborator

Trimmed down PR as requested by @krassowski in #435

@palewire palewire mentioned this pull request Nov 20, 2021
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the bootstrap files intact. If your IDE accidentally added/the new line to the end of the file you can run git checkout js/bootstrap.min.js and git checkout css/bootstrap.min.css to restore them to the previous form.

@palewire
Copy link
Collaborator Author

Sorry @krassowski. I think I got that fixed.

Co-authored-by: Michał Krassowski <[email protected]>
@palewire
Copy link
Collaborator Author

Good call. Thanks.

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@isabela-pf
Copy link
Contributor

As far as I can tell, these are good. Thanks so much for working on this!

@palewire
Copy link
Collaborator Author

palewire commented Dec 1, 2021

Some other PRs introduced a conflict here. I tried to resolve them with the latest commit.

@Carreau
Copy link
Member

Carreau commented Dec 1, 2021

Thanks !

And sorry , I merged all the conflicting PRs and decided it was time to go to lunch before fixing those, but you beat me to it.

@Carreau Carreau merged commit 8ffa219 into jupyter:master Dec 1, 2021
@palewire palewire added this to the Streamline the site milestone Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants