Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Multilingual setup #11 #31

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

573
Copy link

@573 573 commented Jan 10, 2025

Add possibility to have more languages than en (de for now)

Add possibility to have more languages than en (de for now)
joaoymoreira

This comment was marked as outdated.

Copy link

@joaoymoreira joaoymoreira Jan 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should have

#let strings = setstrings(uservars)

#cvheading(cvdata, uservars)
#cvwork(cvdata, strings)
#cveducation(cvdata, strings)
#cvaffiliations(cvdata, strings)
#cvprojects(cvdata, strings)
#cvawards(cvdata, strings)
#cvcertificates(cvdata, strings)
#cvpublications(cvdata, strings)
#cvskills(cvdata, strings)
#cvreferences(cvdata, strings)

besides, i think it could be interesting having a template for each lang, e.g. template.en.typ, template.en.yml, template.de.typ, template.de.yml, etc...

@@ -13,6 +13,7 @@
showTitle: true, // bool
headingsmallcaps: false, // bool
sendnote: false, // bool. set to false to have sideways endnote
lang: en, // format of ISO 639-1/2/3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
lang: en, // format of ISO 639-1/2/3
lang: "en", // format of ISO 639-1/2/3

@joaoymoreira
Copy link

after you get this merged, i can send my changes for region and pt-BR support etc.

@joaoymoreira
Copy link

nevermind, i just created another PR that supersedes this one. i built upon your commit, so you're properly credited.

@573
Copy link
Author

573 commented Jan 20, 2025

thanks @joaoymoreira !

interests: Interessen
awards: Titel und Auszeichnungen
honors: Titel
certificates: Lizensen und Zertifizierungen

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just found this project and the belonging multilingual pull request ^^

Found during usage that there is a small typo, has to be Lizenzen ^^
certificates: Lizenzen und Zertifizierungen

Copy link

@joaoymoreira joaoymoreira Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DerSteph thanks, I fixed it on #32

@573 could you close this pr so people go to #32 instead?

@DerSteph if you could review the other additional de specific things on https://github.com/jskherman/imprecv/pull/32/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants