Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Try to get the pthreads idle example running under docker #401

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions sample/programs/cpp/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
FROM ubuntu:bionic

RUN apt-get update
RUN apt-get install -y build-essential
RUN apt-get install -y linux-tools-common linux-tools-generic
RUN apt-get install -y build-essential linux-tools-common linux-tools-4.15.0-30-generic libpthread-stubs0-dev
RUN ln -sf /usr/lib/linux-tools/4.15.0-30-generic/perf /usr/bin/perf

WORKDIR /workdir

ADD . /workdir

RUN make clean simple-terminates forks
RUN make clean simple simple-terminates forks idle
8 changes: 7 additions & 1 deletion sample/programs/cpp/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,15 @@ forks: forks.cpp
random: random.cpp
$(CXX) -Wall -g -o $@ $<

idle: idle.c
$(CC) -Wall -g -pthread -o $@ $<

linux-perf:
docker container prune -f
docker image rm speedscope-ubuntu || true
docker build -t speedscope-ubuntu .
docker run --privileged speedscope-ubuntu /bin/bash perf-script.sh forks > ../../profiles/linux-perf/forks.linux-perf.txt
docker run --privileged speedscope-ubuntu /bin/bash perf-script.sh idle > ../../profiles/linux-perf/idle.linux-perf.txt
# docker run --privileged speedscope-ubuntu /bin/bash perf-script.sh forks > ../../profiles/linux-perf/forks.linux-perf.txt
# docker run --privileged speedscope-ubuntu /bin/bash perf-script.sh with-header > ../../profiles/linux-perf/simple-with-header.linux-perf.txt
# docker run --privileged speedscope-ubuntu /bin/bash perf-script.sh with-pid > ../../profiles/linux-perf/simple-with-pid.linux-perf.txt
# docker run --privileged speedscope-ubuntu /bin/bash perf-script.sh > ../../profiles/linux-perf/simple.linux-perf.txt
78 changes: 78 additions & 0 deletions sample/programs/cpp/idle.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
// https://github.com/jlfwong/speedscope/issues/393
#include <stdio.h>
#include <unistd.h>
#include <time.h>
#include <pthread.h>
#include <sys/time.h>
#include <sys/types.h>

void fselect() {
fd_set rfds;
struct timeval tv;
int retval;

FD_ZERO(&rfds);
FD_SET(0, &rfds);
tv.tv_sec = 2;
tv.tv_usec = 0;
retval = select(1, &rfds, NULL, NULL, &tv);

if (retval == -1)
perror("select()");
else if (retval)
printf("Data is available now.\n");
/* FD_ISSET(0, &rfds) will be true. */
else
printf("No data within two seconds.\n");
}

void timed(int microseconds) {
int sec, usec, diff;
struct timeval tv;
gettimeofday(&tv, NULL);
// printf("begin seconds : %ld micro seconds : %ld\n", tv.tv_sec, tv.tv_usec);
sec = tv.tv_sec;
usec = tv.tv_usec;

while (1) {
gettimeofday(&tv, NULL);
diff = (tv.tv_sec - sec) * 1000000 + tv.tv_usec - usec;
if (diff > microseconds) {
// printf("end seconds : %ld micro seconds : %ld\n", tv.tv_sec, tv.tv_usec);
break;
}
}
}

void a() { timed(5000); }
void b() { timed(5000); }
void c() { timed(5000); }
void d() { timed(5000); }
void e() { timed(5000); }

void func() {
for (int i = 0; i < 5; i++) {
a();
b();
fselect();
c();
d();
e();
printf("sleep begin\n");
sleep(0.1);
printf("sleep end\n");
}
}

void *fthread(void *args) {
func();
return NULL;
}

int main() {
pthread_t thread;
pthread_create(&thread, NULL, fthread, NULL);

func();
return 0;
}
8 changes: 8 additions & 0 deletions sample/programs/cpp/perf-script.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,14 @@ if [[ "$1" == "forks" ]]; then
exit 0
fi

if [[ "$1" == "idle" ]]; then
perf record -a -F 999 -g ./idle > perf.data

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
perf record -a -F 999 -g ./idle > perf.data
perf record -a -F 999 -g --output=perf.data ./idle

The same applies below and above. These commands aren't printing anything yet, but perhaps it would be worth adding this flag instead as if in the future they print something, perf script and related tooling will break and it will be a bit confusing 😄

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to do something very slightly fancier here, because the stdout of perf-script.sh is used directly to generate the output files in the Makefile, but this --output switch was still a helpful key

echo "Done recording"
ls -alh perf.data
perf script -i perf.data
exit 0
fi

perf record -F 999 -g ./simple-terminates > perf.data

if [[ "$1" == "with-header" ]]; then
Expand Down