-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Try to get the pthreads idle example running under docker #401
Open
jlfwong
wants to merge
3
commits into
main
Choose a base branch
from
jlfwong/perf-idle-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,11 @@ | ||
FROM ubuntu:bionic | ||
|
||
RUN apt-get update | ||
RUN apt-get install -y build-essential | ||
RUN apt-get install -y linux-tools-common linux-tools-generic | ||
RUN apt-get install -y build-essential linux-tools-common linux-tools-4.15.0-30-generic libpthread-stubs0-dev | ||
RUN ln -sf /usr/lib/linux-tools/4.15.0-30-generic/perf /usr/bin/perf | ||
|
||
WORKDIR /workdir | ||
|
||
ADD . /workdir | ||
|
||
RUN make clean simple-terminates forks | ||
RUN make clean simple simple-terminates forks idle |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
// https://github.com/jlfwong/speedscope/issues/393 | ||
#include <stdio.h> | ||
#include <unistd.h> | ||
#include <time.h> | ||
#include <pthread.h> | ||
#include <sys/time.h> | ||
#include <sys/types.h> | ||
|
||
void fselect() { | ||
fd_set rfds; | ||
struct timeval tv; | ||
int retval; | ||
|
||
FD_ZERO(&rfds); | ||
FD_SET(0, &rfds); | ||
tv.tv_sec = 2; | ||
tv.tv_usec = 0; | ||
retval = select(1, &rfds, NULL, NULL, &tv); | ||
|
||
if (retval == -1) | ||
perror("select()"); | ||
else if (retval) | ||
printf("Data is available now.\n"); | ||
/* FD_ISSET(0, &rfds) will be true. */ | ||
else | ||
printf("No data within two seconds.\n"); | ||
} | ||
|
||
void timed(int microseconds) { | ||
int sec, usec, diff; | ||
struct timeval tv; | ||
gettimeofday(&tv, NULL); | ||
// printf("begin seconds : %ld micro seconds : %ld\n", tv.tv_sec, tv.tv_usec); | ||
sec = tv.tv_sec; | ||
usec = tv.tv_usec; | ||
|
||
while (1) { | ||
gettimeofday(&tv, NULL); | ||
diff = (tv.tv_sec - sec) * 1000000 + tv.tv_usec - usec; | ||
if (diff > microseconds) { | ||
// printf("end seconds : %ld micro seconds : %ld\n", tv.tv_sec, tv.tv_usec); | ||
break; | ||
} | ||
} | ||
} | ||
|
||
void a() { timed(5000); } | ||
void b() { timed(5000); } | ||
void c() { timed(5000); } | ||
void d() { timed(5000); } | ||
void e() { timed(5000); } | ||
|
||
void func() { | ||
for (int i = 0; i < 5; i++) { | ||
a(); | ||
b(); | ||
fselect(); | ||
c(); | ||
d(); | ||
e(); | ||
printf("sleep begin\n"); | ||
sleep(0.1); | ||
printf("sleep end\n"); | ||
} | ||
} | ||
|
||
void *fthread(void *args) { | ||
func(); | ||
return NULL; | ||
} | ||
|
||
int main() { | ||
pthread_t thread; | ||
pthread_create(&thread, NULL, fthread, NULL); | ||
|
||
func(); | ||
return 0; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same applies below and above. These commands aren't printing anything yet, but perhaps it would be worth adding this flag instead as if in the future they print something,
perf script
and related tooling will break and it will be a bit confusing 😄There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I needed to do something very slightly fancier here, because the stdout of
perf-script.sh
is used directly to generate the output files in theMakefile
, but this--output
switch was still a helpful key