Make keys the second argument to validations #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 15, 2013 19:44
Added :int and :ints for consistency, :dates was missing.
I've revamped verily to use the notation :validation <keys> [args] [msg] instead of :validation [args] <keys> [msg] That's for three reasons: Ensure key-keyword is distinct from msg-keyword when i18n-support is implemented: [:validation :key <args> :my.custom.msg] The other reason is that it makes the implementation of the type-validation/custom-validation merge in formative slightly simpler. Also, this way it's more consistent, I think. What do you think?
|
That actually breaks the semantic of some validators. Not a good solution, too. |
|
I've added issue #4 to address the underlying requirement here. Closing this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've revamped verily to use the notation
instead of
That's for three reasons:
Ensure key-keyword is distinct from msg-keyword when i18n-support is
implemented:
The other reason is that it makes the implementation of the
type-validation/custom-validation merge in formative slightly simpler.
Also, this way it's more consistent, I think. What do you think?