FinOps on EKS #33
FinOps on EKS #33
Conversation
maria-reynoso
requested review from
davidcollom,
BeckyPauley and
cyberbliss
as code owners
|
|
||
| ### Configuration changes for your cluster environment | ||
|
|
||
| 1. To control which Finops Stack components to install, edit the [enabled.yaml](./installation/config/common/enabled.yaml) file |
There was a problem hiding this comment.
For me, I just want a "default" set of things - coming to it fresh. Is what's enabled in the file in the repo a good starting point?
There was a problem hiding this comment.
Thats the intention, yes. everything in enabled.yaml should be defaulted on for a "default" set of things. enabled.yaml allows for people to toggle features on/off.
There was a problem hiding this comment.
As a newcomer, I don't know what I should/shouldn't install. Are the defaults ok for me to run with? If so, fine - otherwise, we need to briefly document what everything does - the comments in the files are not really enough at the moment
| @@ -1,3 +1,4 @@ | |||
| {{ if and .Values.dashboards }} | |||
There was a problem hiding this comment.
NIT:
| {{ if and .Values.dashboards }} | |
| {{ if .Values.dashboards }} |
and would only be needed if there were multiple conditions, there is only one defined.
| @@ -0,0 +1,79 @@ | |||
| # Installation using Helmfile | |||
There was a problem hiding this comment.
This doc really needs a bit more context - could you add a para to the top explaining what the doc is about? Also, could you update the README.md file in the directory - at the moment, I'd expect to go to that file and be pointed to the different ways to install, rather than just using that for kind... Does that make sense?
There was a problem hiding this comment.
@maria-reynoso Please could you change the README.md so that it explains that we have three different ways of installing (GKE, EKS, and Kind)? It is very confusing at the mo!
| ### Configuration changes for your cluster environment | ||
|
|
||
| 1. To control which Finops Stack components to install, edit the [enabled.yaml](./installation/config/common/enabled.yaml) file | ||
| 1. Copy `./env_eks.tmpl` to `./.env` and replace the env var values accordingly. |
There was a problem hiding this comment.
"replace the env var values accordingly" hides a lot of stuff and a lot of confusion, particularly because there are GKE-related env vars in there. Can we remove them?
| set -a; source .env; set +a; helmfile apply --file Helmfile_eks.yaml --interactive --skip-deps | ||
| ``` | ||
|
|
||
| ## Optional: Configure ingress for Grafana |
There was a problem hiding this comment.
Suggest re-wording to "Making Grafana accessible via DNS"
|
|
||
| ### Pre-requisites | ||
|
|
||
| Already have an FQDN setup and registered with a public IP, e.g. grafana.example.com |
There was a problem hiding this comment.
Presumably this isn't actually needed, and you could edit /etc/hosts to point to a public IP?
No description provided.