Add line breaks #36
Open
Add line breaks #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when we run this task in our CI, our output looks like this: ``` /home/circleci/bundler-cache/****/2.7.0/gems/net-protocol-0.2.1/lib/net/protocol.rb:68: warning: already initialized constant Net::ProtocRetryError /usr/local/lib/****/2.7.0/net/protocol.rb:66: warning: previous definition of ProtocRetryError was here /home/circleci/bundler-cache/****/2.7.0/gems/net-protocol-0.2.1/lib/net/protocol.rb:214: warning: already initialized constant Net::BufferedIO::BUFSIZE /usr/local/lib/****/2.7.0/net/protocol.rb:206: warning: previous definition of BUFSIZE was here /home/circleci/bundler-cache/****/2.7.0/gems/net-protocol-0.2.1/lib/net/protocol.rb:541: warning: already initialized constant Net::NetPrivate::Socket /usr/local/lib/****/2.7.0/net/protocol.rb:503: warning: previous definition of Socket was here WARNING: Skipping foo.bar_id: it has multiple associations referencing different keys/tables. WARNING: Skipping foo.bar_id: it has multiple associations referencing different keys/tables. WARNING: Skipping foo.bar_id: it has multiple associations referencing different keys/tables. WARNING: Skipping foo.bar_id: it has multiple associations referencing different keys/tables. WARNING: Skipping foo.bar_id: it has multiple associations referencing different keys/tables. Missing foreign key relationship on 'new_table.new_column_id' to 'other_table.id' Found missing foreign keys, run `rails generate immigration MigrationName` to create a migration to add them. ``` There is a lot of noise (that's not this gem's fault) and then the useful message right at the bottom. A lot of that noise is repeated across many CI tasks and it's on us to fix it. But anyway... I've seen two cases recently where someone has glossed over the really useful message at the bottom because of all the noise above it. So I'm proposing to add some line breaks to make the actionable bit stand out.
joshuay03
added a commit
to TandaHQ/immigrant
that referenced
this pull request
May 8, 2024
Ref: jenseng#36 Co-authored-by: Alex Ghiculescu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when we run this task in our CI, our output looks like this:
There is a lot of noise (that's not this gem's fault) and then the useful message right at the bottom. A lot of that noise is repeated across many CI tasks and it's on us to fix it. But anyway...
I've seen two cases recently where someone has glossed over the really useful message at the bottom because of all the noise above it. So I'm proposing to add some line breaks to make the actionable bit stand out.