Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't cache whole scripts in development mode, allows sub resources to hot reload again #279

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't cache whole scripts in development mode, allows sub resources to hot reload again #279

wants to merge 1 commit into from

Conversation

timja
Copy link
Member

@timja timja commented Oct 29, 2021 •
edited
Loading

Alternative to #278

Tested and it works, seems snappy enough but would appreciate feedback

Fixes #221

cc @basil if you have any opinion

@timja timja added the bug label Oct 29, 2021
@timja timja requested a review from jglick October 29, 2021 10:40
This was referenced Oct 29, 2021
Open
Open
jglick
jglick reviewed Oct 29, 2021
View reviewed changes
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC this will only cache custom taglibs, which is a use case most plugins do not even touch except insofar as they might use some from core (mainly in configuration screens with /lib/form).

@timja
Copy link
Member Author

timja commented Oct 29, 2021

IIUC this will only cache custom taglibs, which is a use case most plugins do not even touch except insofar as they might use some from core (mainly in configuration screens with /lib/form).

correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick left review comments

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subresources not reloaded in development mode
2 participants
@timja @jglick