Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't serialize user displayname as change entry changeuser #227

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

stuartrowe
Copy link
Contributor

Fix for https://issues.jenkins.io/browse/JENKINS-75263.

In order to avoid calling the deprecated and slow hudson.model.User.get(String idOrFullName) attempt to look up a user by id using the p4 login name to match an existing user with hudson.model.User.getById(String id, boolean create). If the the look up by id fails fallback to the existing lookup by fullname.

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@stuartrowe stuartrowe changed the title Attempt to lookup user by login name before falling back to by fullname Don't serialize user displayname as change entry changeuser Feb 13, 2025
@stuartrowe stuartrowe marked this pull request as ready for review February 13, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant