Add support for coverage thresholds and tolerance of minor drops in coverage in Github status checks #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-fredrickson
force-pushed
the
storpeyCHT/compare-with-tolerance
branch
from
6941080 to
c4dd08c
Compare
…overage in status checks
michael-fredrickson
force-pushed
the
storpeyCHT/compare-with-tolerance
branch
from
c4dd08c to
d6b4c8b
Compare
|
👍 to this idea! This is pretty cool, but I'm wondering if it would be better if the |
msabramo
suggested changes
Jan 14, 2021
| statusMessage = message.forThresholdStatusCheck( settingsRepository.getGreenThreshold() ); | ||
| } else if ("tolerance".equalsIgnoreCase(comparisonMode)){ | ||
| float tolerance = settingsRepository.getTolerance(); | ||
| float result = Math.abs(coverage - targetCoverage) * 100; |
There was a problem hiding this comment.
This is incorrect, because it will result in coverage increases causing failures. I think this should be:
float result = (targetCoverage - coverage) * 100;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds two new features which are adding support for Github status checks with the defined coverage threshold as well as a tolerance option to address minor drops in code coverage which can fail a build outlined in issue #84.
Here are some screenshots of the default behavior as well as demonstrations of each of these two features passing and failing a build.
Default:
Thresholds:
Tolerance:
