Merge token_blacklist migrations into one (#615) #781
Conversation
afoalb
commented
Feb 8, 2024
•
afoalb
commented
- Initial migrations defined id as AutoField, later migrations changed the type to BigAutoField. This conversion is not allowed in MSSQL.
- Initial migrations defined id as AutoField, later migrations changed the type to BigAutoField. This conversion is not allowed in MSSQL
for more information, see https://pre-commit.ci
afoalb
changed the title
|
I ran all tox tests locally and they all passed. Not clear why they are failling here on github |
There was a problem hiding this comment.
By default, Postgres favors BigAutoField. Talking about database-specific implementations:
AutoField as 32-bit INT, and BigAutoField to its 64-bit BIGINT character, in both MySQL and MariaDB.
Notably, AutoField maps to INT (32-bit) or BIGINT (64-bit) depending on DEFAULT_AUTO_FIELD setting or explicit field declaration - which by default is AutoField in django unless otherwise specified.
That said, this is a good move, and should we get the tests up, would be merging this MR
|
On deeper considerations, let's review the backwards compatibility that might revolve around this change - potential impact on existing projects. Thoughts? |
|
Hi, any updaes? |
|
This would break backwards compatibility. Unlike SQLAlchemy which stores the last migrated revision id, Django migrations are managed by storing each migration name in the database (IIRC). This would still not be great for users who haven't upgraded simplejwt. If we're looking for MSSQL changes, consider checking whether the database type is MSSQL then run an MSSQL specific change. |
