Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multipart/form-data requests*** #704

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
21 changes: 17 additions & 4 deletions silk/model_factory.py
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,16 @@ def construct_request_model(self):
query_params = self.query_params()
path = self.request.path
view_name = self.view_name()
content_type = self.request.content_type

if content_type.startswith('multipart/form-data'):
body = {
'form_data': self.request.POST.dict(),
'files': {f: self.request.FILES[f].name for f in self.request.FILES}
}
raw_body = None # Raw body is not available for multipart/form-data
else:
body, raw_body = self.body()
Comment on lines +229 to +238
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ziyacivan Good catch, and thank you for making this patch! 👏🏼

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thank you so much! I couldn't continue to the development process (means is tests) because of my social life issues, thank you again 👏🏽


request_model = models.Request.objects.create(
path=path,
Expand All @@ -234,12 +244,15 @@ def construct_request_model(self):
query_params=query_params,
view_name=view_name,
body=body)

# Text fields are encoded as UTF-8 in Django and hence will try to coerce
# anything to we pass to UTF-8. Some stuff like binary will fail.
try:
request_model.raw_body = raw_body
except UnicodeDecodeError:
Logger.debug('NYI: Binary request bodies') # TODO
if raw_body is not None:
try:
request_model.raw_body = raw_body
except UnicodeDecodeError:
Logger.debug('NYI: Binary request bodies') # TODO

Logger.debug('Created new request model with pk %s' % request_model.pk)
return request_model

Expand Down