Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add actor email #641

Merged
merged 1 commit into from
Jan 30, 2025
Merged

add actor email #641

merged 1 commit into from
Jan 30, 2025

Conversation

hamedsh
Copy link
Contributor

@hamedsh hamedsh commented May 7, 2024

add actor_email

deleting a user from the Users table will make actor_id useless (its only a bunch of characters). by adding email as static content, it can be usable forever.

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.52%. Comparing base (5289482) to head (61a25d9).
Report is 35 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #641      +/-   ##
==========================================
+ Coverage   95.21%   95.52%   +0.30%     
==========================================
  Files          31       33       +2     
  Lines        1025     1094      +69     
==========================================
+ Hits          976     1045      +69     
  Misses         49       49              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hramezani
Copy link
Member

Thanks @hamedsh for this PR. Please

  • Add change log entry for this change
  • Add some tests to show 1. email will be logged in LogEntry model and 2. email will remain in after user deletion

@hramezani hramezani requested a review from aleh-rymasheuski May 7, 2024 19:43
@hamedsh hamedsh force-pushed the add_actor_email branch 2 times, most recently from 08cdd17 to b352e55 Compare January 22, 2025 07:35
@hamedsh
Copy link
Contributor Author

hamedsh commented Jan 22, 2025

Thanks @hamedsh for this PR. Please

  • Add change log entry for this change
  • Add some tests to show 1. email will be logged in LogEntry model and 2. email will remain in after user deletion

@hramezani can you please take a look?

auditlog/context.py Outdated Show resolved Hide resolved
@hramezani
Copy link
Member

Thanks @hamedsh for updating the PR. I left a comment. Also, please rebase and add a changelog entry in https://github.com/jazzband/django-auditlog/blob/master/CHANGELOG.md

@hamedsh hamedsh force-pushed the add_actor_email branch 2 times, most recently from b462634 to 65257f7 Compare January 30, 2025 07:43
@hamedsh hamedsh requested a review from hramezani January 30, 2025 07:45
@hramezani
Copy link
Member

Thanks @hamedsh

@hramezani hramezani merged commit 602c760 into jazzband:master Jan 30, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants