-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add actor email #641
add actor email #641
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #641 +/- ##
==========================================
+ Coverage 95.21% 95.52% +0.30%
==========================================
Files 31 33 +2
Lines 1025 1094 +69
==========================================
+ Hits 976 1045 +69
Misses 49 49 ☔ View full report in Codecov by Sentry. |
Thanks @hamedsh for this PR. Please
|
08cdd17
to
b352e55
Compare
@hramezani can you please take a look? |
Thanks @hamedsh for updating the PR. I left a comment. Also, please rebase and add a changelog entry in https://github.com/jazzband/django-auditlog/blob/master/CHANGELOG.md |
b462634
to
65257f7
Compare
65257f7
to
61a25d9
Compare
Thanks @hamedsh |
add actor_email
deleting a user from the Users table will make actor_id useless (its only a bunch of characters). by adding email as static content, it can be usable forever.