Don't write atime file if JAX_COMPILATION_CACHE_MAX_SIZE == -1 #26529
+28
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The atime file is only needed to implement the LRU eviction policy, which is only needed if a max persistence compilation cache size is set. Writing this file can cause network filesystem performace and other issues, so only write it if users are opted-in.
skye
changed the title
ayaka14732
requested changes
Feb 14, 2025
| @@ -94,7 +94,6 @@ def get(self, key: str) -> bytes | None: | |||
| raise ValueError("key cannot be empty") | |||
|
|
|||
| cache_path = self.path / f"{key}{_CACHE_SUFFIX}" | |||
| atime_path = self.path / f"{key}{_ATIME_SUFFIX}" | |||
There was a problem hiding this comment.
We should keep the atime_path definition here because it's clearer and it will not actually write the file.
There was a problem hiding this comment.
I disagree! I think variables only used in a conditional scope should be defined in the conditional scope. See the one true style guide: https://google.github.io/styleguide/cppguide.html#Local_Variables ("Place a function's variables in the narrowest scope possible")
Co-authored-by: Ayaka <[email protected]>
ayaka14732
requested changes
Feb 14, 2025
Co-authored-by: Ayaka <[email protected]>
Co-authored-by: Ayaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The atime file is only needed to implement the LRU eviction policy, which is only needed if a max persistence compilation cache size is set. Writing this file can cause network filesystem performace and other issues, so only write it if users are opted-in.