Refactor Jax FFI lowering to prepare for implementing CPU/GPU callbacks using XLA's FFI. #26168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_720649341
branch
from
1ccf4db to
c152cec
Compare
copybara-service
bot
force-pushed
the
test_720649341
branch
7 times, most recently
from
aa1c040 to
ece52b5
Compare
…ks using XLA's FFI. - This refactor just moves code around and should have no impact on tests or public-facing APIs. - `mlir.emit_python_callback` would eventually depend on `ffi.ffi_lowering`, which in turn depends on definitions in `mlir.py`. We break this circular dependency. PiperOrigin-RevId: 720649341
copybara-service
bot
force-pushed
the
test_720649341
branch
from
ece52b5 to
6f679d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Jax FFI lowering to prepare for implementing CPU/GPU callbacks using XLA's FFI.
mlir.emit_python_callbackwould eventually depend onffi.ffi_lowering, which in turn depends on definitions inmlir.py. We break this circular dependency.