docs: outdated link for index update syntax #26082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfm
requested changes
Jan 24, 2025
There was a problem hiding this comment.
Thanks! This looks good to me.
Small request: Do you think you could revert the unrelated changes in the rendered thinking_in_jax.ipynb? The easiest way would probably be to check out the notebook from main and then open it in a text editor to change just the link, rather than opening it as a notebook? Thank you!!
jakevdp
requested changes
Jan 24, 2025
There was a problem hiding this comment.
Could we revert the unrelated changes to the notebook? It looks like it's mostly re-rendering outputs, including PNGs, and that's not part of the intent of this PR.
|
Oops, my IDE's git integration did not show me those changes. On it, thanks for the reviews! |
Saransh-cpp
force-pushed
the
index-update-syntax-link
branch
from
a54ac29 to
9e89ae7
Compare
google-ml-butler
bot
added
kokoro:force-run
pull ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jax.ops.index_update,jax.ops.index_add, ..., were deprecated in 0.2.22.