[shard_map] fix jax.debug.print/callback under partial auto #25887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjj
force-pushed
the
partial-auto-something
branch
2 times, most recently
from
6147eab to
64b0bb6
Compare
mattjj
changed the title
mattjj
force-pushed
the
partial-auto-something
branch
2 times, most recently
from
6bf215b to
1039edd
Compare
pschuh
approved these changes
Jan 15, 2025
mattjj
added
pull ready
mattjj
added
pull ready
mattjj
added
pull ready
Co-authored-by: Parker Schuh <[email protected]>
mattjj
force-pushed
the
partial-auto-something
branch
from
1039edd to
3681960
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes
jax.debug.printwork under a partial-auto shard_map. I think it's an alternative to #25705 which doesn't need openxla/xla#20944.While this makes
jax.debug.printwork today, corresponding with the semantics of today, #25842 points to deeper improvements we still want to make.