[pallas] Support DMA start partial discharge and run_scoped() does its own partial discharge. #25775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_713280422
branch
4 times, most recently
from
8701c81 to
719d0de
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_713280422
branch
4 times, most recently
from
0971b32 to
a114f6a
Compare
copybara-service
bot
force-pushed
the
test_713280422
branch
3 times, most recently
from
2efe956 to
5f038eb
Compare
copybara-service
bot
force-pushed
the
test_713280422
branch
from
5f038eb to
ad16c70
Compare
copybara-service
bot
force-pushed
the
test_713280422
branch
from
ad16c70 to
31c6806
Compare
…s own partial discharge. This CL lays the ground for a future CL that makes run_scoped discharge to not request the discharge of the temporary buffers it creates. This causes issues becausa a) dma_start can't discharge some but not all its references b) run_scoped() lowering depends on run_scoped discharge to remove the run_scoped operation (or it goes in an infinite loop). PiperOrigin-RevId: 722126566
copybara-service
bot
force-pushed
the
test_713280422
branch
from
31c6806 to
8649132
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[pallas] Support DMA start partial discharge and run_scoped() does its own partial discharge.
This CL lays the ground for a future CL that makes run_scoped discharge to not request the discharge of the temporary buffers it creates. This causes issues becausa
a) dma_start can't discharge some but not all its references
b) run_scoped() lowering depends on run_scoped discharge to remove the run_scoped operation (or it goes in an infinite loop).