Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor of util_agent_message_actions_staging_rsa.go #285

Merged
merged 4 commits into from
Dec 15, 2023
Merged

Refactor of util_agent_message_actions_staging_rsa.go #285

merged 4 commits into from
Dec 15, 2023

Conversation

Edznux
Copy link
Contributor

@Edznux Edznux commented May 16, 2023 •
edited
Loading

Discussion issue: #286

  • Added tests (minimal, just to make sure we catch simplest errors, 100% code coverage is a non goal :))
  • Guarded clauses
  • extracted constant string (SQL queries) into a package constant

Edznux added 3 commits May 17, 2023 00:44
@Edznux
Add mythic server binary gitignore
b8e1631
@Edznux
Refactor util_agent_message_actions_staging_rsa.go
e42020c 
This refactor uses common patterns in Go such as (but not limited to):
return early/Guard Clause, unit tests, definition of constants variables
@Edznux
Refactor and add test for rsa/crypto generation
69854ee
@Edznux Edznux mentioned this pull request May 16, 2023
Open
@Edznux Edznux marked this pull request as draft May 16, 2023 23:05
@Edznux Edznux marked this pull request as ready for review May 18, 2023 13:26
@its-a-feature its-a-feature merged commit 52ac930 into its-a-feature:master Dec 15, 2023
@Ne0nd0g Ne0nd0g mentioned this pull request Dec 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Edznux @its-a-feature