Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i1] Optimization to add packed_storage to i1 tensor #19604

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

[i1] Optimization to add packed_storage to i1 tensor #19604

wants to merge 10 commits into from

Conversation

lialan
Copy link
Contributor

@lialan lialan commented Jan 5, 2025 •
edited
Loading

  • A new optimization pass as part of GlobalOptimization pipeline
  • Finds tensor inputs with i1 element types, and attach packed_storage attribute to it.
  • Provides finer control via commandline option: which ones to pack and which ones to not pack.

@lialan lialan requested a review from rsuderman January 6, 2025 01:31
@lialan lialan mentioned this pull request Jan 6, 2025
Open
lialan added 9 commits January 8, 2025 06:44
@lialan
[i1] Implement packed_storage layout encoding attribute
fa8b6cd 
* make `packed_storage` as a type of `iree_encoding` attribute, and make type converters accept it.
* `i1` tensors with `#iree_encoding.packed_storage` will be interpreted as packed i1 type, same as specifying `--iree-experimental-packed-i1-storage`.
* `--iree-experimental-packed-i1-storage` are kept for testing purposes. We can drop this option after frontend enables emitting `i1` tensors with attributes.

Signed-off-by: Alan Li <[email protected]>
@lialan
Small refactor the Bazel file
882bf99
@lialan
pass's first commit
e0fe048
@lialan
checkpoint
fba4383
@lialan
updates
37d6f9f
@lialan
Updates
a7ca57a
@lialan
implement more things
9bde48c
@lialan
check in
4e91971
@lialan
temp updates
3d89e69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsuderman rsuderman Awaiting requested review from rsuderman

@hanhanW hanhanW Awaiting requested review from hanhanW hanhanW will be requested when the pull request is marked ready for review hanhanW is a code owner

@bjacob bjacob Awaiting requested review from bjacob bjacob will be requested when the pull request is marked ready for review bjacob is a code owner

@benvanik benvanik Awaiting requested review from benvanik benvanik will be requested when the pull request is marked ready for review benvanik is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lialan