[i1] Remove command line option to enable packed storage #19528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* make `packed_storage` as a type of `iree_encoding` attribute, and make type converters accept it. * `i1` tensors with `#iree_encoding.packed_storage` will be interpreted as packed i1 type, same as specifying `--iree-experimental-packed-i1-storage`. * `--iree-experimental-packed-i1-storage` are kept for testing purposes. We can drop this option after frontend enables emitting `i1` tensors with attributes. Signed-off-by: Alan Li <[email protected]>
lialan
force-pushed
the
lialan/i1_attr
branch
from
3099d0b to
419ee6b
Compare
lialan
force-pushed
the
lialan/bitcast
branch
from
9159d90 to
e27a766
Compare
lialan
force-pushed
the
lialan/i1_attr
branch
from
d26a392 to
7ac00fe
Compare
lialan
force-pushed
the
lialan/bitcast
branch
from
e27a766 to
7f752a4
Compare
|
This is a successor, improving PR to #19354 |
lialan
force-pushed
the
lialan/bitcast
branch
from
bd53c95 to
b17ea2f
Compare
This reverts commit 547cee9.
|
The diff is off. There are some changes from #19354. E.g., the below is not part of this PR, right? 
Can you rebase and fix it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#iree_encoding.packed_storageto designate if ani1tensor is of packed memory layout.iree-experimental-packed-i1-storagecommand line option.