Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use global browser instead of webextension-polyfill #839

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sidvishnoi
Copy link
Member

@sidvishnoi sidvishnoi commented Jan 16, 2025

Context

We don't need the polyfill except for async message handlers in background.

Changes proposed in this pull request

Remove polyfilled browser from content scripts and React apps to reduce bundle size, and have less JS in content scripts (as they get injected into each frame in each tab) for better performance.

Keeping it draft until we add more E2E tests.

Zip size went down 20KB only (duplication compresses better in zip). Unzipped size went 2.09MB from to 2.03MB (60KB).

@github-actions github-actions bot added area: content Improvements or additions to extension content script area: popup Improvements or additions to extension popup area: pages/app area: pages/notification area: pages Changes to any of extension's pages area: shared Changes to shared libraries and utilities labels Jan 16, 2025
Copy link
Contributor

Extension builds preview

Name Link
Latest commit db5cbb6
Latest job logs Run #12808853982
BadgeDownload
BadgeDownload

Copy link
Member Author

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-e2e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: content Improvements or additions to extension content script area: pages/app area: pages/notification area: pages Changes to any of extension's pages area: popup Improvements or additions to extension popup area: shared Changes to shared libraries and utilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant