Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Bindless][E2E] Fix post-commit from PR #16537 #16691

Merged

Conversation

przemektmalon
Copy link
Contributor

This patch should fix the post-commit failure resulting from enabling the 3-channel image PR in #16537

This is done by adding a // REQUIRES-INTEL-DRIVER: comment for LIT to ignore the test until the necessary driver for the functionality is introduced to the GitHub CI.

This patch should fix the post-commit failure resulting from enabling
the 3-channel image PR in intel#16537

This is done by adding a `// REQUIRES-INTEL-DRIVER:` comment for LIT to
ignore the test until the necessary driver for the functionality is
introduced to the GitHub CI.
@przemektmalon
Copy link
Contributor Author

@wenju-he, I have used the oldest Linux driver version (32370) you mentioned supports the 3-channel capability for Intel.

Do you know what the corresponding Windows version of the driver should be? Then I can add that win: <driver_version> to the // REQUIRES-INTEL-DRIVER line.

@przemektmalon przemektmalon changed the title [SYCL][Bindless][E2E] Fix post-commit from PR 16537 [SYCL][Bindless][E2E] Fix post-commit from PR #16537 Jan 20, 2025
@wenju-he
Copy link
Contributor

Do you know what the corresponding Windows version of the driver should be? Then I can add that win: <driver_version> to the // REQUIRES-INTEL-DRIVER line.

I don't know about this. As I see, the latest internal release 101.6330 still uses neo 31441.
@AshwinKumarKulkarni could you help here?

Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm merging this now because CI has been broken for days. Please address the Windows driver restriction in a separate PR.

@sarnex sarnex merged commit 4c7d48d into intel:sycl Jan 21, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants