Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Bindless][E2E] Enable 3-channel image test for Intel GPUs #16537

Merged
merged 6 commits into from
Jan 17, 2025
Merged

[SYCL][Bindless][E2E] Enable 3-channel image test for Intel GPUs #16537

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a2a8324
[SYCL][Bindless][E2E] Enable 3-channel image test for Intel GPUs
przemektmalon Jan 7, 2025
21b0a65
Change channel type to ushort
przemektmalon Jan 8, 2025
4e2fd26
Merge branch 'sycl' into przemek/test-3-channel-intel
przemektmalon Jan 8, 2025
c3f5db4
Use (ushort * 3) as sizeof(sycl::ushort3) == 8
przemektmalon Jan 10, 2025
e5627a2
Merge branch 'sycl' into przemek/test-3-channel-intel
przemektmalon Jan 10, 2025
8e18e4d
Formatting
przemektmalon Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions sycl/test-e2e/bindless_images/3_channel_format.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// REQUIRES: cuda
// REQUIRES: aspect-ext_oneapi_bindless_images

// RUN: %{build} -o %t.out
// RUN: %{run} %t.out
// RUN: %{run-unfiltered-devices} env NEOReadDebugKeys=1 UseBindlessMode=1 UseExternalAllocatorForSshAndDsh=1 %t.out

#include <iostream>
#include <sycl/detail/core.hpp>
Expand All @@ -21,19 +21,22 @@ int main() {
auto ctxt = q.get_context();

constexpr size_t width = 512;
std::vector<float> out(width);
std::vector<float> expected(width);
std::vector<sycl::float3> dataIn(width);
float exp = 512;
for (int i = 0; i < width; i++) {
std::vector<unsigned short> out(width);
std::vector<unsigned short> expected(width);
std::vector<unsigned short> dataIn(width * 3);
unsigned short exp = 512;
for (unsigned int i = 0; i < width; i++) {
expected[i] = exp;
dataIn[i] = sycl::float3(exp, width, i);
dataIn[(i * 3)] = exp;
dataIn[(i * 3) + 1] = static_cast<unsigned short>(width);
dataIn[(i * 3) + 2] = static_cast<unsigned short>(i);
}

try {
// Main point of this test is to check creating an image
// with a 3-channel format
syclexp::image_descriptor desc({width}, 3, sycl::image_channel_type::fp32);
syclexp::image_descriptor desc({width}, 3,
sycl::image_channel_type::unsigned_int16);

syclexp::image_mem imgMem(desc, dev, ctxt);

Expand All @@ -46,7 +49,7 @@ int main() {
syclexp::unsampled_image_handle imgHandle =
sycl::ext::oneapi::experimental::create_image(imgMem, desc, dev, ctxt);

sycl::buffer<float> buf(out.data(), width);
sycl::buffer<unsigned short> buf(out.data(), width);

q.submit([&](sycl::handler &cgh) {
sycl::accessor outAcc{buf, cgh};
Expand All @@ -55,9 +58,9 @@ int main() {
#if defined(__SYCL_DEVICE_ONLY__) && defined(__NVPTX__)
// This shouldn't be hit anyway since CUDA doesn't support
// 3-channel formats, but we need to ensure the kernel can compile
using pixel_t = sycl::float4;
using pixel_t = sycl::ushort4;
#else
using pixel_t = sycl::float3;
using pixel_t = sycl::ushort3;
#endif
auto pixel = syclexp::fetch_image<pixel_t>(imgHandle, int(id[0]));
outAcc[id] = pixel[0];
Expand All @@ -83,7 +86,7 @@ int main() {
}

bool validated = true;
for (int i = 0; i < width; i++) {
for (unsigned int i = 0; i < width; i++) {
bool mismatch = false;
if (out[i] != expected[i]) {
mismatch = true;
Expand Down
Loading